Add back link to Design heading in site editor navigation to return to Dashboard #47950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
glendaviesnz
commented
Feb 10, 2023
| @@ -12,10 +12,11 @@ import useNavigator from '../use-navigator'; | |||
| import type { NavigatorBackButtonProps } from '../types'; | |||
|
|
|||
| export function useNavigatorBackButton( | |||
| props: WordPressComponentProps< NavigatorBackButtonProps, 'button' > | |||
| props: WordPressComponentProps< NavigatorBackButtonProps, 'button' > | any | |||
There was a problem hiding this comment.
just a temporary hack of course until we decide if href should be added to this component or not.
|
Size Change: +45 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Need to do some investigation into why the |
|
Flaky tests detected in 7cf4947. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4167695723
|
youknowriad
reviewed
Feb 10, 2023
packages/edit-site/src/components/sidebar-navigation-screen/index.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Feb 10, 2023
packages/edit-site/src/components/sidebar-navigation-screen/index.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Feb 13, 2023
youknowriad
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
LGTM 👍 I'd appreciate a quick check from design cc @jameskoster
jameskoster
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
The inconsistent behavior of this button feels a bit awkward, and that's a shame. But it's important to acknowledge the feedback in #47583, and with one eye on the future I think it makes sense to merge this change.
youknowriad
added
the
Backport to WP 6.7 Beta/RC
glendaviesnz
force-pushed
the
add/back-link-to-dashboard
branch
from
450eaa2 to
7cf4947
Compare
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 0342acd |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 14, 2023
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
|
Thank you @glendaviesnz for working on this PR! |
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a backlink to the Design heading in the Site Editor browse mode nav panel
Why?
To provide a more obvious link back to the Dashboard
Fixes: #47583
How?
Adds a
Buttoncomponent with anhrefback to the Dashboard. ANavigatorBackButtonwas not used as it does not have anhrefparam and is designed for navigation within theNavigatorcomponent only.Testing Instructions
Screenshots or screencast
Before:
After: