-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete failing test for Font Size Picker #47913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes sense but I think I check "merged when all tests pass" checkbox. Weird :)
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
Flaky tests detected in 467f977. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4132991593
|
In #47356 (comment) the behavior for font size picker was changed to always consider a custom value as
custom
, even there is a matched preset.This PR removes the obsolete failing test. The
set custom size
behavior is tested in a separate test(should apply a custom font size using the font size input
)