ToolsPanel: Display optional items when values are updated externally #47727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
This was referenced Feb 3, 2023
|
Size Change: -32 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 816afb5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4119298207
|
talldan
added
the
Backport to WP 6.7 Beta/RC
|
Confirmed that this works as expected. I see the controls populate with proper values when copying styles from one block to another. ✅ |
|
@aaronrobertshaw this tested well for me with a single block selection, but not multiselection, so taking a look to see if I can work out why that is - but might be worth merging as is if that is not an easy fix as a single block is probably the most likely use case. |
glendaviesnz
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
LGTM:
✅ Unit tests pass
✅ Storybook examples work the same as on trunk
✅ Pasting styles optional tools panel items causes the tools panel to rerender with the new controls in place with the correct settings
✅ Additional optional controls not in the pasted group are reset but still render
As already noted it doesn't work for multi-selected blocks but we should go ahead and merge this as the main use case will be single blocks and we can handle multi-selects separately later.
aaronrobertshaw
force-pushed
the
try/fix-toolspanel-on-paste-styles
branch
from
9785486 to
816afb5
Compare
ntsekouras
pushed a commit
that referenced
this pull request
Feb 9, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47368
Related:
What?
Potentially fixes design tools not showing in the inspector when pasting block styles.
Note: If an optional control has been toggled on, or customized previously, then block styles are pasted, that optional control will continue to be displayed. It will reflect the current value though. Reselect the block, and that control will be hidden, as per normal.
Does this behaviour actually help highlight to the user what's changed?
Why?
When pasting styles, their values should be reflected in the design tools without having to de-select and re-select the block.
How?
Allows optional ToolsPanelItems to override the ToolsPanel's inner menu item state when the optional item previously wasn't toggled on for display.
Testing Instructions
npm run test:unit packages/components/src/tools-panel/testnpm run storybook:dev- Ensure no behavioural differences between trunk and this branch. Particularly with the conditional item examples.Screenshots or screencast
Screen.Recording.2023-02-03.at.5.36.02.pm.mp4