Block Directory: Optimize DownloadableBlocksPanel
#47679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
requested review from
Mamaduka,
youknowriad,
ryelle,
jsnajdr,
flootr,
jorgefilipecosta and
ntsekouras
tyxla
added
[Type] Performance
|
Size Change: +41 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c148f12. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4073301940
|
Mamaduka
reviewed
Feb 2, 2023
I can't really reproduce, here's what I'm seeing:
Do you see any errors in the console, or any network request failures? |
Mamaduka
approved these changes
Feb 2, 2023
This is a good sign, it means that the filter with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the performance of the
DownloadableBlocksPanelcomponent by reducing the unnecessary updates done to the downloadable blocks (thedownloadableItemsprop). This allows us to avoid unnecessary extra updates when the parent component is re-rendered, but an update is triggered just because we return a new array with the same data.Why?
When typing into the main inserter we see a bunch of updates coming from
DownloadableBlocksPanelwith almost always the samedownloadableItemsarray contents, but with a different reference.How?
We're doing a couple of optimizations:
downloadableItemsis an empty array, we make sure to always return the same empty array.downloadableItems, since the installable blocks will always contain a new array (as it is the result ofArray.prototype.filter()).Testing Instructions
Testing Instructions for Keyboard
None.
Screenshots or screencast
None.