Pattern Explorer Modal: Select the first category as the initial category #47661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the pattern explorer modal.
apeatling
added
the
[Feature] Patterns
|
Size Change: +223 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d078387. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4074247106
|
Mamaduka
reviewed
Feb 2, 2023
packages/block-editor/src/components/inserter/block-patterns-tab.js
Outdated
Show resolved
Hide resolved
Mamaduka
added
[Type] Regression
carolinan
approved these changes
Feb 2, 2023
…ab.js Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
|
Thanks for the reviews! 👍 |
Mamaduka
added a commit
that referenced
this pull request
Feb 3, 2023
…gory (#47661) * Pass the first pattern category as the initially selected category in the pattern explorer modal. * If there is a selected category, make sure we use that instead. * Update packages/block-editor/src/components/inserter/block-patterns-tab.js Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> --------- Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
|
I just cherry-picked this PR to the release/15.1 branch to get it included in the next release: 8a15ceb |
Mamaduka
removed
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47657
What?
If no inserter sidebar pattern category has been selected, make sure the first pattern category is selected as the initially selected category in the pattern explorer modal.
Why?
This seems to be a regression, where there's no pattern category selected when the modal first opens so the whole thing is empty. This is only if no pattern category has been selected in the inserter sidebar.
How?
Take the first category object in the
categoriesarray and pass that asinitialCategory.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After:
