Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Bump Android minSdkVersion to 24 #47604

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 31, 2023

What?

Update Android minSdkVersion to match the value set in WordPress-Android (PR reference).

Why?

This change is part of an ongoing effort for updating the minSdkVersion to 24 on all libraries used in WordPress-Android.

How?

Update the value to 24 in all references of minSdkVersion in Gutenberg.

Testing Instructions

This change should have no impact on the editor, so there are no specific areas that we'd need to test. It should be enough by smoke testing the demo app and check the app compiles successfully.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A

@fluiddot fluiddot added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Mobile App - Automation Label used to initiate Mobile App PR Automation labels Jan 31, 2023
@fluiddot fluiddot self-assigned this Jan 31, 2023
Copy link
Contributor

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :shipit:

@fluiddot fluiddot merged commit 27bd8bf into trunk Jan 31, 2023
@fluiddot fluiddot deleted the rnmobile/bump-android-min-sdk-version branch January 31, 2023 15:59
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants