Add https option to prependUrl util #47312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +25 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1dc407e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3966426233
|
getdave
changed the title
getdave
changed the title
draganescu
reviewed
Jan 26, 2023
Because I didn't want to introduce a change to the default return value that could have ripple effects outside of this change. No other reason. |
|
Is there any way to get it to always be "CURRENT_PROTOCOL"? |
What does that value represent? I don't follow. I'm working on an alternative PR to this one which I will push up shortly which simply uses https by default. |
Somehow just use whatever the current protocol is in the browser. If the user is on http use http if the user is on https use https. |
Ah I see. Nonetheless, I think these functions should be idempotent. I don't think they should change behaviour depending on the environment in which they being run. |
I agree with this sentiment FWIW. I laid some suggestions in #47467 (comment) and I think given the context here, it might be best to introduce |
100%. Should have thought of that. I think
is better. @getdave is the above suggestion very annoying 🙏🏻 ? |
Nope let's go with that. I'll raise a PR 👍 |
|
Follow up #47648 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add ability to use the
httpsprotocol when consuming theprependHttputil.Part of #46244
Why?
Needed for #46244
How?
Add option. Add tests.
Testing Instructions
Run
npm run test:unit packages/url/src/test/index.jsTesting Instructions for Keyboard
Screenshots or screencast