Blocks: Update ToggleControl to pass boolean onChange #4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Blocks
noisysocks
approved these changes
Jan 29, 2018
| id={ id } | ||
| checked={ checked } | ||
| onChange={ this.onChange } | ||
| aria-describedby={ !! help ? id + '__help' : undefined } |
There was a problem hiding this comment.
Nit: this !! isn't necessary.
There was a problem hiding this comment.
Good call! Simplified in a721c08.
aduth
added
the
[Type] Breaking Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4613
This pull request seeks to change the argument signature of the
onChangecallback ofInspectorControls.ToggleControl, passing a boolean value instead of the event object, for consistency with other inspector controls.Existing core blocks tend to ignore this argument altogether, instead opting to infer the change as toggle of the current value (i.e.
setAttributes( { checked: ! checked } );).Testing instructions:
Verify there are no regressions in behavior of any block using the
InspectorControls.ToggleControlblock helper component:https://github.com/WordPress/gutenberg/search?utf8=%E2%9C%93&q=togglecontrol&type=