Tests: Use real timers where fake timers are unnecessary #47144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Automated Testing
tyxla
requested review from
Mamaduka,
mirka,
jsnajdr,
ciampo,
flootr,
chad1008,
ntsekouras and
brookewp
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
This was referenced Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates more tests across the various packages to use real timers where possible. This is a follow-up to #46714 and #47056.
There are more tests that use fake timers, but this PR doesn't attempt to attack them all. Many of them actually make sense to use fake timers anyway.
Why?
We discovered that Jest real timers are preferable when their use is possible, see facebook/react#25889 and the description in #46714.
How?
We're removing the specific
jest.useFakeTimers();calls, and the unnecessaryadvanceTimers: jest.advanceTimersByTimein the user-event setup. We're also removing the now unnecessaryjest.advanceTimersByTime()calls and post-test cleanup that we've been doing withjest.runOnlyPendingTimers()andjest.useRealTimers().Testing Instructions
Verify all tests still pass.
Testing Instructions for Keyboard
None
Screenshots or screencast
None.