Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local() from generated webfonts styles #47137

Closed
wants to merge 3 commits into from
Closed

Conversation

aristath
Copy link
Member

What?

This PR removes the local() generated styles from the webfonts API.

Why?

Apparently, using local() in @font-face styles generated from the Webfonts API is causing some issues for users: #42190

@github-actions
Copy link

github-actions bot commented Jan 13, 2023

Flaky tests detected in 9b8c9b5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3910756777
📝 Reported issues:

@aristath aristath marked this pull request as ready for review January 13, 2023 08:35
@Luehrsen
Copy link
Contributor

Maybe relevant as well:

https://core.trac.wordpress.org/ticket/57430

@hellofromtonya
Copy link
Contributor

@Luehrsen The Core Trac ticket will likely be closed if the Fonts API makes it into 6.2. Why? Because this enhancement will be part of the API when it gets backported. If it doesn't get backported, then decisions can be made about whether to change what's in Core now. I'll comment on that Trac ticket.

@hellofromtonya
Copy link
Contributor

The Fonts API renaming merged today. That means this PR will need to be rebased and the changes applied to the new API. @aristath it might be easier to close this PR and reopen a new one.

@hellofromtonya
Copy link
Contributor

Thinking about it. I'll open a new PR and apply your changes @aristath to it.

@hellofromtonya
Copy link
Contributor

Closed in favor of #47254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong local font file being referenced by @font-face generated from theme.json
3 participants