-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Learn more about CSS" help text to Custom CSS control #47091
Conversation
Size Change: -2 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this link is important.
Hopefully the part about needing to save is self explanatory. Otherwise we can use a text that only mentions saving, and leaves out the template context?
Glen is AFK at the moment, so I'll try to be a stand in reviewer. The change looks good to me, so I'll merge it. Thanks for working on it 🎉 It'd be good to start a secondary task to update the documentation as I noticed it says this:
It could additionally mention global styles now. |
I think the docs should be updated once it is not experimental and not limited to the plugin. |
What?
Closes #46669 by replacing the redundant help text with the same "Learn more about CSS" link that currently exists in the Customizer.
Why?
How?
Leverages the ExternalLink component, using the same link that is currently employed in the Customizer.
Testing Instructions
Screenshot
Current:
Suggested: