Inner Blocks: Fix provides context condition #46729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
tyxla,
youknowriad and
ntsekouras
and removed request for
ellatrix
Mamaduka
added
[Type] Bug
Mamaduka
commented
Dec 22, 2022
| if ( | ||
| Object.keys( blockType?.providesContext ?? {} ).length === 0 | ||
| ) { | ||
| return { name: block.name }; |
There was a problem hiding this comment.
The name is used later to get the block layout. Since early return wasn't working, not returning it was never an issue.
|
Size Change: +19 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Dec 22, 2022
I'm definitely planning to do that as a part of my next PR. I just need to figure out the right amount of "unit" to test 😅 |
|
The mobile version of the if ( blockType && blockType.providesContext ) { /* ... */ }And it's always truthy as well? If true, this component should get the same fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes early return condition check when block type doesn't provide context.
Why?
The default
providesContextvalue is an empty object. Since its truthy value, the early return condition was never met.The
getBlockContextwill return a new object on every attribute change and cause extra re-render. This is another issue I'm trying to solve.How?
Use
Object.keysto check if the block type defines the context to provide.Testing Instructions
Testing Instructions for Keyboard
Doesn't affect UI.