-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accessing potentially undefined block editor setting __experimentalBlockInspectorAnimation #46570
Merged
getdave
merged 1 commit into
trunk
from
fix/access-prop-of-potentially-undefined-block-editor-setting
Dec 15, 2022
Merged
Fix accessing potentially undefined block editor setting __experimentalBlockInspectorAnimation #46570
getdave
merged 1 commit into
trunk
from
fix/access-prop-of-potentially-undefined-block-editor-setting
Dec 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
scruffian,
MaggieCabrera,
artemiomorales,
ajlende and
draganescu
December 15, 2022 07:15
getdave
added
[Type] Bug
An existing feature does not function as intended
[Block] Navigation
Affects the Navigation Block
[Type] Experimental
Experimental feature or API.
[Package] Block editor
/packages/block-editor
and removed
[Block] Navigation
Affects the Navigation Block
labels
Dec 15, 2022
talldan
approved these changes
Dec 15, 2022
getdave
changed the title
Fix accessing portneitally undefined block editor setting __experimentalBlockInspectorAnimation
Fix accessing potentially undefined block editor setting __experimentalBlockInspectorAnimation
Dec 15, 2022
Size Change: +10 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
getdave
deleted the
fix/access-prop-of-potentially-undefined-block-editor-setting
branch
December 15, 2022 09:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Block editor
/packages/block-editor
[Type] Bug
An existing feature does not function as intended
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes JS error when attempting to access property of potentially undefined
__experimentalBlockInspectorAnimation
added in #46342.Why?
The following error was thrown upon selecting the block:
This only happened when the Nav block offcanvas experiment was on.
This was due to accessing a property of a object which is potentially undefined. Block settings are not guaranteed to be available.
How?
Use conditional chaining to guard accessing the prop returning
undefined
if not available.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast