Migrate quote e2e tests to playwright #46549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Dec 14, 2022
| await page.keyboard.press( 'ArrowRight' ); | ||
| await page.keyboard.type( '2' ); | ||
| expect( await editor.getEditedPostContent() ).toMatchSnapshot(); | ||
| await pageUtils.pressKeyTimes( 'ArrowLeft', 4 ); |
There was a problem hiding this comment.
Originally, the arrow-left was used for keystrokes.
However, as discovered in this comment, the arrow-up key may cause unstable behavior depending on the theme, so it is rewritten as the arrow-left key.
There was a problem hiding this comment.
Maybe we should leave an inline comment here. What do you think?
t-hamano
added
the
[Type] Automated Testing
t-hamano
changed the title
|
Size Change: +1.42 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Thanks for working on this, @t-hamano 🦸 The migration looks great, and I will review this first thing tomorrow 👍
The updated guidelines haven't been merged yet, but the inline snapshot would be preferred here. Plus, we don't have a block assertions helper in place yet. See the rendered document about snapshot assertions: https://github.com/WordPress/gutenberg/blob/f2d2fa14f18ba1d257ede08b714940d4c3ba5590/docs/contributors/code/e2e/overusing-snapshots.md. |
|
Thanks for the info, @Mamaduka! I have read the update guidelines. Personally, I think inline snapshots are appropriate for this test, but if the approach using |
|
@t-hamano, using inline snapshots with |
|
I replaced it with an inline snapshot. |
Mamaduka
approved these changes
Dec 15, 2022
Comment on lines
+6
to
+10
| test.describe( 'Quote', () => { | ||
| test.beforeEach( async ( { admin } ) => { | ||
| await admin.createNewPost(); | ||
| } ); | ||
|
|
There was a problem hiding this comment.
We should probably clean up after all tests are done.
test.afterAll( async ( { requestUtils } ) => {
await requestUtils.deleteAllPosts();
} );There was a problem hiding this comment.
Done.
By the way, I think that once #46459 is merged, The clean-up might no longer be needed 🤔
There was a problem hiding this comment.
Thanks. That would be great. We can remove post-cleanup methods after that is confirmed in #46459.
| await page.keyboard.press( 'Enter' ); | ||
| await page.keyboard.type( 'two' ); | ||
| await page.keyboard.down( 'Shift' ); | ||
| await page.click( '[data-type="core/paragraph"] >> nth=0' ); |
There was a problem hiding this comment.
Suggestion: You can use role selector + explicit text for the block. Maybe something like this:
await page.click( 'role=document[name="Paragraph block"i] >> text=one' );P.S. I've tested this selector in this case, but have used similar one before :)
| await page.keyboard.press( 'ArrowRight' ); | ||
| await page.keyboard.type( '2' ); | ||
| expect( await editor.getEditedPostContent() ).toMatchSnapshot(); | ||
| await pageUtils.pressKeyTimes( 'ArrowLeft', 4 ); |
There was a problem hiding this comment.
Maybe we should leave an inline comment here. What do you think?
I have added the following comment, is it appropriate? // Move the cursor to the start of the first paragraph of the quoted block.
await pageUtils.pressKeyTimes( 'ArrowLeft', 4 ); |
|
Thanks again. Feel free to merge after all checks are green ✅ |
dmsnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Migrate qupte e2e tests to playwright * Use inline snapshots * Add `deleteAllPosts` * Use accesible selector * Add an inline comment for `pressKeyTimes`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Migrate
quote.test.jsto its Playwright version.Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test:e2e:playwright test/e2e/specs/editor/blocks/quote.spec.jsNote