Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Add "custom-css" as an acceptable value in the docs for gutenberg_get_global_stylesheet #46493

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Global Styles: Add "custom-css" as an acceptable value in the docs for gutenberg_get_global_stylesheet #46493

merged 1 commit into from
Dec 13, 2022

Conversation

aristath
Copy link
Member

Follow-up to #46141

What?

In https://github.com/WordPress/gutenberg/pull/46141/files#diff-cedd84c7ed1db0edc59408b4ee36590a340ed11b5c36a77732026518db0f3e7aR88 we added custom-css in gutenberg_get_global_stylesheet. However, the function's docs were not updated to mirror that change. This PR adds the custom-css value as an acceptable value in the function's docs.

@aristath aristath added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 13, 2022
Mamaduka
Mamaduka approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@Mamaduka Mamaduka added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Dec 13, 2022
@aristath aristath enabled auto-merge (squash) December 13, 2022 08:14
@glendaviesnz
Copy link
Contributor

Thanks @aristath!

@aristath aristath merged commit 98409e9 into trunk Dec 13, 2022
@aristath aristath deleted the tweak-inline-docs-for-custom-css branch December 13, 2022 08:32
@github-actions github-actions bot added this to the Gutenberg 14.8 milestone Dec 13, 2022
@ryanwelcher ryanwelcher changed the title Add "custom-css" as an acceptable value in the docs for gutenberg_get_global_stylesheet Global Styles: Add "custom-css" as an acceptable value in the docs for gutenberg_get_global_stylesheet Dec 14, 2022
@Mamaduka Mamaduka mentioned this pull request Jan 17, 2023
Closed
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@glendaviesnz glendaviesnz Awaiting requested review from glendaviesnz

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 14.8
Development

Successfully merging this pull request may close these issues.
3 participants
@aristath @glendaviesnz @Mamaduka