E2E tests: Add width and color test to button block #46452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
t-hamano
commented
Dec 11, 2022
t-hamano
commented
Dec 11, 2022
Comment on lines
+251
to
+253
| await page.click( | ||
| 'role=button[name=/^Gradient control point at position 0% with color code/]' | ||
| ); |
There was a problem hiding this comment.
The button to change the point of the gradient actually has the following text:
Gradient control point at position 0% with color code rgb(6,147,227).
I used forward matching because rgb values may change with WordPress and Gutenberg updates.
There was a problem hiding this comment.
For other themes, the test will fail because the selectors in the gradient palette don’t match.
Is this still true if we use regex matching here?
t-hamano
added
the
[Type] Automated Testing
kevin940726
reviewed
Dec 11, 2022
|
@kevin940726 |
kevin940726
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
LGTM 👍.
While I have concerns for overusing snapshots here but we don't have other easy alternatives for now until #45709 (reviews/feedback welcome!).
I think we also use twentytwentyone locally too, no? |
For some reason, the switch to Twenty Twenty One doesn't seem to be working in my environment ( Is this a problem with my environment or is it not intended? |
|
Interesting. 🤔 Yeah, it's not intended, I thought it would always use twentytwentyone. |
Perhaps the theme switching doesn't occur when running a specific test? If so, that would make sense. |
|
Found the bug! Opened #46459. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #29992
What?
This PR adds a test for width and colors (text, background color, gradient color) to the E2E test for the button block.
Why?
To cover more test cases and to prevent regressions reported in #29992.
How?
This test adds the following five test cases:
Testing Instructions
Run either of the following:
npm run test:e2e:playwright test/e2e/specs/editor/blocks/buttons.spec.jsnpm run test:e2e:playwright test/e2e/specs/editor/blocks/buttons.spec.js -- --headed