Global Styles: Fix duplication of synced block colors in CSS output #46297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
8 tasks
|
Size Change: -9.42 kB (-1%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Thanks for cleaning this up 👍
✅ Could replicate original issue
✅ Template part outlines and icons still have purple color in the list view and block card
✅ Reusable block has colored icon in list view and block card
✅ Only one instance of the --wp-block-synced-color custom CSS properties are included on the frontend after applying this PR
LGTM! 🚢
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
ryanwelcher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves the setting of the custom CSS properties for the color of the synced blocks from
_colors.scssto_default-custom-properties.scssWhy?
Because the rest of
_colors.scssfile is just variables having custom properties there caused them to be output in multiple block style definitions.How?
Moved the definitions from one file to another
Testing Instructions
root: { --wp-synced-blockisn't repeated multiple times in block style outputsN.B You may need to restart the watch/build process after switching to this branch to get the duplicate styles to disappear
Screenshots or screencast
Before:
After: