Fix the navigate regions focus style on Safari #46118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Focus] Accessibility (a11y)
|
Size Change: -1.17 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
I tested on Safari and this PR fixes the issue.
I did a brief check on Chrome & Firefox and didn't see any regressions.
I'll go ahead and approve this PR as I think it's good to be merged, but as an additional precaution, it would be beneficial if someone else also tests other browsers to be 100% certain there's no regressions 👍
|
@afercia can you please rebase this PR? Hopefully that will fix the issue with stuck tests and resolve the conflict 👍 |
|
The CSS changes in this PR applied to a 'stacker' that has been removed in #46525. As such, these changes aren't applicable any longer. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46111
What?
Under some conditions, Safari exhibits a bug where the Navigate regions focus style is not visible on the content area. This appears to be a browser issue, as Safari is known to have problems with z-indexes.
Why?
The Navigate regions focus style must be visible.
How?
Uses
transform: translateZ(0);, which is known to fix some painting issues in Safari. This new CSS rule shouldn't affect anything as it basically doesn't do anything.Testing Instructions
Screenshots or screencast