Navigator: Split NaviagtorContainer from NavigatorProvider
#46099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Code Quality
noisysocks
requested review from
ajitbohra,
ellatrix,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
|
|
@ciampo: What do you think of this refactor? Needed so that I can have navigator links for the Styles panel that live outside of the Styles panel in #45960. (You click on the block in the Style Book and it navigates to the block's screen in Styles.) Two alternative approaches I can think of:
Alternative 1 above is kinda tempting. But would splitting |
|
Size Change: +115 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
noisysocks
commented
Nov 28, 2022
| let { children } = contextProps; | ||
|
|
||
| const hasScreenChildren = Children.toArray( children ).some( | ||
| ( child ) => isValidElement( child ) && child.type === NavigatorScreen |
There was a problem hiding this comment.
Hm, actually, this doesn't really work in practice because children are often a component that wraps NavigatorScreen e.g. GlobalStylesNavigatorScreen.
I'm going to go with this approach. That way all of the work can stay in |
noisysocks
deleted the
update/split-navigator-container-from-provider
branch
|
I never actually wondered if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Splits a new
NavigatorContainercomponent from the existingNavigatorProvidercomponent. This means thatNavigatorProviderwill provide a context and not render anything.Why?
This allows me to hoist
NavigatorContextup to the root of the site editor and placeNavigatorLinks in places outside of the Styles panel'sNavigatorProvider. See #45960.How?
Moves the non-context logic out of
NavigatorProviderand intoNavigatorContainer. Backwards compatibility is maintained by havingNavigatorProviderwrap its children withNaviagtorContainerif it detects aNavigatorScreenchild.Testing Instructions
Screenshots or screencast