Navigation: Move add a submenu option to the top of the list #46076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Block] Navigation
scruffian
requested review from
draganescu,
getdave,
MaggieCabrera and
ajlende
|
|
scruffian
commented
Nov 25, 2022
| @@ -226,6 +226,8 @@ export function BlockSettingsDropdown( { | |||
| <__unstableBlockSettingsMenuFirstItem.Slot | |||
| fillProps={ { onClose } } | |||
| /> | |||
| </MenuGroup> | |||
| <MenuGroup> | |||
There was a problem hiding this comment.
This means all items added using __unstableBlockSettingsMenuFirstItem will be in a MenuGroup.
scruffian
commented
Nov 25, 2022
| > | ||
| { __( 'Add a submenu item' ) } | ||
| </MenuItem> | ||
| <__unstableBlockSettingsMenuFirstItem> |
There was a problem hiding this comment.
This is the only change here. The rest is indentation.
|
Size Change: +14 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
getdave
reviewed
Nov 28, 2022
| > | ||
| { __( 'Add a submenu item' ) } | ||
| </MenuItem> | ||
| <__unstableBlockSettingsMenuFirstItem> |
There was a problem hiding this comment.
Won't this mean that Add a submenu shows for all block types?
There was a problem hiding this comment.
Oh I see. Might as well close this then!
|
This approach doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves the "Add a submenu" option to the top of the block settings dropdown. Also add a line beneath it.
Why?
This is a primary action so it should be at the top of the list.
How?
Using
__unstableBlockSettingsMenuFirstItem. This also wraps__unstableBlockSettingsMenuFirstItemin aMenuGroupwhich adds a line beneath it, but this has the unfortunate consequence that any items added using__unstableBlockSettingsMenuFirstItemwill also be in a different group.We might also want to remove the "Hide more settings" option. I started doing that here: #46077
Testing Instructions
...next to the custom linkScreenshots or screencast