Enable easier drag and drop for navigation building #45906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…drag and drop in list view
|
|
|
Size Change: +82 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
draganescu
added
[Type] Enhancement
|
This is working nicely! I tried it with social links and a site logo blocks too and they all move correctly |
MaggieCabrera
approved these changes
Nov 21, 2022
talldan
reviewed
Nov 21, 2022
| @@ -544,7 +547,7 @@ export default function NavigationLinkEdit( { | |||
| if ( hasChildren ) { | |||
| transformToSubmenu(); | |||
| } | |||
| }, [] ); | |||
| } ); | |||
There was a problem hiding this comment.
Looks like the dependency list was removed?
This code wasn't great in trunk, so there's an opportunity to improve it.
I think it'd be better to split it into two effects. A first for the setIsLinkOpen part, which would have url as a dep, the other for the transformToSubmenu part which would have hasChildren as a dep.
| if ( ! hasChildren ) { | ||
| transformToLink(); | ||
| } | ||
| } ); |
There was a problem hiding this comment.
Missing dependencies here too.
draganescu
changed the title
|
I found a bug, trying to remove one of the menu items via the 3 dots menu, this is not happening on trunk:
|
If I have a custom link with no URL selected I can't get rid of this popover:
In trunk, if I remove focus from the block the popover disappears |
|
Also, if there nothing below it a submenu, I can't get the last item to drag and drop outside the submenu:
https://user-images.githubusercontent.com/275961/203051979-578f2e82-ec54-42f5-aa98-5f14c9d1f61f.mp4
|
|
I also find the drop position to create a submenu very unintuitive, but that might be outside the scope of this PR
https://user-images.githubusercontent.com/275961/203053002-54fb9806-4b20-41b6-9f74-988ccfd206f5.mp4
|
|
@scruffian the bits about dragging the last item and about the drop position are pertaining to the list view's drag and drop nesting in general. |
Co-authored-by: Daniel Richards <677833+talldan@users.noreply.github.com> Co-authored-by: Maggie <3593343+MaggieCabrera@users.noreply.github.com> Co-authored-by: Ben Dwyer <275961+scruffian@users.noreply.github.com>
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR makes the drag and drop of navigation inner blocks more seamless.
Why?
With the addition of a list view in the navigation block's inspector drag and drop should work seamlessly for its allowed inner blocks. This isn't the case now:
This is unexpected and makes the UX cumbersome. We have some items that were stop gap solutions such as:
These are also in need of simplification.
How?
To do:
Testing Instructions
Screenshots or screencast
drag-drop-menu-building.mp4