[Inserter]: Remove Reusable tab and move the contents inside Blocks tab
#45847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Inserter
|
|
|
Size Change: -202 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
|
The manage button seems a bit too prominent. Perhaps we could put it in a row with the category name?
|
|
I like your latest design, Jay, but per this comment perhaps we should go with #45851 for now. There are many inserter flows to untangle regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove Reusable tab and move the contents inside Blocks tab
Testing Instructions
reusable block.Reusabletab is not thereBlockstab the reusable blocks should be shown as the end of the core categories(afterembedcategory)Screenshots or screencast
Screen.Recording.2022-11-17.at.2.27.57.PM.mov
Notes
If we go with this approach, we will need feedback/testing from the mobile team.