Extract the manage menus button to a shared component to reduce duplicate code #45769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +12 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Nov 15, 2022
| const ManageMenusButton = ( { buttonClassName = '' } ) => ( | ||
| <Button | ||
| variant="link" | ||
| disabled={ ! hasManagePermissions || ! hasResolvedNavigationMenus } |
There was a problem hiding this comment.
These could be provided as props. This would make the component more isolated from it's environment and make it easier to extract to a separate file in future.
There was a problem hiding this comment.
I agree here. Let's move ManageMenusButton outside the Navigation component and accept disabled as a prop.
There's no need to recreate React component on every rerender.
There was a problem hiding this comment.
Done here: #45782
scruffian
force-pushed
the
update/manage-menus-button
branch
from
8cb9463 to
e27ca92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This refactors the manage menus button to a shared component.
Why?
This code is reused many times, so we should only have one copy of it.
How?
Extracts this button to a functional component so it can be reused.
Testing Instructions
Check that the manage menus button still appears in the same place with the off canvas editing experiment enabled/disabled.
Screenshots or screencast
Experiment disabled:
Experiment enabled:
