Experimental list view duplicate for use in navigation list view experiment #45518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
draganescu
changed the base branch from
trunk
to
add/navigation-off-canvas-edit-experiment
|
Size Change: +4.63 kB (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
add/experimental-duplicate-of-list-view
branch
from
0e1441a to
b791c55
Compare
draganescu
requested review from
ajitbohra,
ntwb,
nerrad,
geriux,
ryanwelcher,
juanmaguitar and
fabiankaegy
draganescu
force-pushed
the
add/navigation-off-canvas-edit-experiment
branch
from
599e3f4 to
2c03fd2
Compare
draganescu
changed the base branch from
add/navigation-off-canvas-edit-experiment
to
trunk
draganescu
changed the base branch from
trunk
to
add/navigation-off-canvas-edit-experiment
draganescu
force-pushed
the
add/navigation-off-canvas-edit-experiment
branch
from
2c03fd2 to
3c5d618
Compare
draganescu
force-pushed
the
add/experimental-duplicate-of-list-view
branch
from
b791c55 to
3c5d618
Compare
This reverts commit 814861d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a spin off from #44534.
It introduces a duplicated list view component and exports it as experimental.
To do:
Why?
This is created so that UX chaneges can be iterated on feaster inside of the experiment.
How?
Copy paste the list view component.
Changed name.
Export changed name.
Document changed name.
The only new thing is renaming the top most component to __ExperimentalOffCanvasEditor and exporting it. All else is identical in this PR to __ExperimentalListView
Testing Instructions
Check the diff.
Screenshots or screencast
N/A