Pullquote block: Unify cite element to block level #45403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Block] Pullquote
t-hamano
commented
Oct 30, 2022
Comment on lines
-59
to
-77
| .wp-block-pullquote cite { | ||
| color: inherit; | ||
| } |
There was a problem hiding this comment.
This style was already defined and removed due to duplication.
|
Size Change: -2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
force-pushed
the
enhancement/pullquote-cite-block
branch
from
02d0ceb to
e50eb0b
Compare
|
I would like to work on deprecating pullquote blocks, so I would like to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
In #11610, it is being considered to deprecate the Pullquote block. If the Pullquote block is deprecated, I think this PR can be closed.
What?
This PR Unify cite element to block level.
Why?
On the editor,
citeelement is aRichTextcomponent, sodisplay:blockis applied. However, on the front end, the display property is not defined. Sincecitetag is a text-level semantics, browsers should render it asdisplay:inlineby default. Therefore, the margins between the quote text and the cite text are slightly wider than those on the editor.Editor
Front end
How?
display:blockapplied to the front-end cite element.Testing Instructions
Note: Twenty Twenty Three uses
clampfor font size, so it would be difficult to accurately compare the differences between the editor and the front end.Twenty Twenty Two or emptytheme would be appropriate.