-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Site editor clips body background style #45261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
An existing feature does not function as intended
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
Oct 25, 2022
Size Change: +10 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
fix/site-editor-body-background
branch
from
October 25, 2022 12:09
f98a5f2
to
977cf53
Compare
ockham
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Approving, based on my notes on the WP 6.1 PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR applies the fix backported to WordPress 6.1 by #45118 to the latest Gutenberg.
Why?
Background on this issue is discussed in detail in #44374 (comment). The complication is that this problem cannot be reproduced in the usual way as long as Gutenberg plugin is enabled.
How?
Same changes as #45118.
Testing Instructions
To test this PR, follow the "Testing Instructions" in #45118.