Replace the MainDashboardButton slot with a setting in the site editor #45149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
|
|
Size Change: -85 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
packages/edit-site/src/components/navigation-sidebar/navigation-panel/index.js
Show resolved
Hide resolved
16 tasks
youknowriad
force-pushed
the
replace/main-dashboard-button-slot
branch
from
d78e7a8 to
68a22ab
Compare
|
I've checked wpdirectory and this is not used at all. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #44770 we're redesigning the sidebar of the site editor and it highlighted that the
__experimentalMainDashboardButtonslot was not a semantic API that adapts to the design changes. So I'm replacing it with a setting (dashboardUrl) to allow potential third-party devs to actually replace the back URL.