Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List view: Modify the shortcut to focus while open #45135

Merged
merged 22 commits into from
Feb 14, 2023
Merged

List view: Modify the shortcut to focus while open #45135

merged 22 commits into from
Feb 14, 2023

Commits on Nov 19, 2022

  1. Modify shortcut to focus list view when it is open.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    d260440 View commit details
    Browse the repository at this point in the history

  2. Remove extra state and figure out activeElement from ref.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    066f0e8 View commit details
    Browse the repository at this point in the history

  3. Try a sneaky way of making shortcut work even on close button focus.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    6e32429 View commit details
    Browse the repository at this point in the history

  4. Fix static checks.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    581582e View commit details
    Browse the repository at this point in the history

  5. Modify selector.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    d640d77 View commit details
    Browse the repository at this point in the history

  6. Export isListViewOpen function.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    c937d41 View commit details
    Browse the repository at this point in the history

  7. Add E2E test for new functionality.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    32abd0b View commit details
    Browse the repository at this point in the history

  8. Fix focus events now that list view sidebar contains outline tab.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    ebe6b94 View commit details
    Browse the repository at this point in the history

  9. Update E2E.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    a416421 View commit details
    Browse the repository at this point in the history

  10. Update E2E.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    ca30209 View commit details
    Browse the repository at this point in the history

  11. Do not render ListView if there are no blocks.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    5c0c934 View commit details
    Browse the repository at this point in the history

  12. Fix focus for no blocks.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    2ffefe0 View commit details
    Browse the repository at this point in the history

  13. Fix focus on mount.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    5593e6d View commit details
    Browse the repository at this point in the history

  14. Move functionality to callback function entirely.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    e5605d4 View commit details
    Browse the repository at this point in the history

  15. Fix E2E.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    5d214ff View commit details
    Browse the repository at this point in the history

  16. Remove merge artifact.

    @alexstine
    alexstine committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    40ec3bb View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2022

  1. Merge branch 'trunk' of github.com:wordpress/gutenberg into try/list-… 

    …view-modify-shortcut-focus
    @alexstine
    alexstine committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    47bbedc View commit details
    Browse the repository at this point in the history

  2. Fix tests.

    @alexstine
    alexstine committed Dec 25, 2022
    1 Configuration menu
    Copy the full SHA
    34224f3 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Merge branch 'trunk' of github.com:wordpress/gutenberg into try/list-… 

    …view-modify-shortcut-focus
    @alexstine
    alexstine committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    b9821b0 View commit details
    Browse the repository at this point in the history

  2. Prevent scroll on focus.

    @alexstine
    alexstine committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    7945440 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Rework code.

    @alexstine
    alexstine committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3fec919 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' of github.com:wordpress/gutenberg into try/list-… 

    …view-modify-shortcut-focus
    @alexstine
    alexstine committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    fe9aa36 View commit details
    Browse the repository at this point in the history