SpacingSizesControl: Increase slider's max value to 300 #44956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100px is a little restrictive when it comes to padding and margin sizes. Let's try bumping that up to 300px.
noisysocks
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
|
From memory the thinking behind the 100 limit was because with the short length of the range control in this context limits above this make it harder to adjust in pixel increments, eg. setting say Either way it can be manually adjusted in the input box. I don't have a strong opinion either way. Is it something to run past some of the accessibility people - fine motor control accessibility issues were raised when the range control was initially added to the spacing presets? |
jasmussen
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Thank you! This feels great to me:
I think we could even go higher than 300, but this seems a big step forward.
I understand the motor control argument, but in practice it doesn't seem problematic to me. Especially since it's paired with multiple additional affordances, the main being to just type in a precise number. You can also click/drag in the box, or you can use up/down arrows to increment/decrement, and you can add shift to that mix to skip in increments of 10. In that light, the slider is truly extra, and a nice way to see a big shift that's okay to be imprecise.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
The slider next to a padding or margin control currently maxes out at 100px. This feels a little too restrictive—let's try bumping it up to 300px.
Note that you can enter any value you want into the text field.
Testing Instructions
Screenshots or screencast
Kapture.2022-10-14.at.11.08.26.mp4