New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Try] Validate tabs in inserterMenu before render #4488

Closed

andreilupu wants to merge 1 commit into WordPress:master from andreilupu:try/3992-hide-empty-tabs

Contributor

andreilupu commented Jan 15, 2018

Description

I would like to give a shot at #3992

How Has This Been Tested?

I will work on some Jest test if the PR makes sense as UX first.

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows has proper inline documentation.


          validate inserterMenu tabs before render

03832ef

Contributor Author

andreilupu commented Jan 18, 2018

hmm after #4497 was merged I see a different way of doing this. Closing to avoid PR spam atm

andreilupu closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet