[Block Settings]: Show move to on nested blocks when only one root block
#44827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: -4 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 10, 2022
packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js
Show resolved
Hide resolved
ntsekouras
force-pushed
the
fix/move-to-with-nested-blocks
branch
from
d071108 to
f429892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #41889
"Move to" in the block settings dropdown only shows if there is more than one top-level block. For example, if all the post content is contained inside a Columns block, it is not possible to use the "Move to" feature on any of its inner blocks.
This PR fixes that by checking the parents block count
Testing Instructions
Groupblock, and add onlyoneblock inside it.Move tois not shown for both blocks.GroupblockMove tois shown in the block settings dropdown for any of those blocks inside the Group block.Move tois not shown on the parentGroupblock.Move tois shown to every root block