Fix alignments for children of Query block. #44144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
tellthemachines
requested review from
glendaviesnz,
talldan and
andrewserong
|
Size Change: +22 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Nice one, thanks for finding a fix for this @tellthemachines. Glad it was a simple change copying over the logic from the Group block! I wonder if longer term it's worth us creating a common layout utility function that wraps this logic for easy use (not a blocker for this PR, of course).
This is testing well for me; with this PR applied I can now see the additional alignment controls at the Post Template level and the classnames are output in the site editor:
LGTM! Also, once this PR is merged, should we cherry pick it into the release/14.1 branch so it makes it into this GB release?
andrewserong
added
the
Backport to Gutenberg RC
|
Thanks for reviewing @andrewserong !
Ideally we can find a way to make this block support work without having to explicitly pass layout to the inner blocks, which would incidentally fix #43731 😄 If/when we do that, perhaps we can remove this logic altogether 🤞
Yes! |
24 tasks
|
@tellthemachines @andrewserong I'm constantly following the progress you're making here, still hoping that we'll get |
cbravobernal
pushed a commit
that referenced
this pull request
Sep 15, 2022
ockham
added
the
Backport to WP 6.7 Beta/RC
ockham
pushed a commit
that referenced
this pull request
Sep 19, 2022
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: f70250a |
ockham
removed
the
Backport to WP 6.7 Beta/RC
20 tasks
andrewserong
added
the
[Feature] Layout
13 tasks
aaronrobertshaw
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Children of the Query block weren't being passed all the data on their parent's layout, so they weren't getting the full set of alignment controls when Query had "Inner blocks use content width" set.
Fixes an issue reported on TT3.
Why?
How?
Testing Instructions
Screenshots or screencast