List: improve writing flow #43954
Merged
List: improve writing flow #43954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.41 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
I tested this and found the following:
A probably unrelated observation:
|
draganescu
approved these changes
Sep 12, 2022
|
@draganescu Could you report that as a separate issue? |
|
Thanks for the review :) |
michalczaplinski
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently, when using Arrow keys, the list item wrapper is selected before placing the caret inside the list. This is different from how the previous version worked and it now takes more key presses to navigate through a list.
This happens because we have an extra div wrapper in list items to handle nested lists. While #41655, would fix this, we need a temporary solution for now.
Why?
Writing flow is worse than before.
How?
I changed writing flow to skip tubbable elements if that element only contains one child that is editable.
Testing Instructions
We have pretty good e2e coverage and we'll need to update those tests.
Screenshots or screencast