SearchControl: Convert to TypeScript and add flag to remove bottom margin #43871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2022
mirka
commented
Sep 5, 2022
| @@ -72,6 +78,7 @@ function SearchControl( | |||
| > | |||
| <div className="components-search-control__input-wrapper"> | |||
| <input | |||
| { ...restProps } | |||
There was a problem hiding this comment.
|
Size Change: +12 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Sep 5, 2022
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
mirka
force-pushed
the
ts-search-control
branch
from
a93075e
to
525dd66
Compare
Ah thanks, I messed that up. In 525dd66 I fixed it so the |
ciampo
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
🚀
In 525dd66 I fixed it so the onClose action spy is only passed in the onClose story. I also improved the story/prop description a bit to clarify its usage.
That is an unexpected behavior that the component is having 🤔 but anyway, not the scope of this PR.
cbravobernal
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38730 #35744
What?
__nextHasNoMarginBottomprop to remove the bottom margin.Why?
Better docs, better reusability.
Testing Instructions
npm run storybook:devand check the SearchControl stories in Docs view.