-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Set the icon control to full width. #43844
Merged
kevin940726
merged 1 commit into
trunk
from
fix/full-width-icon-control-navigation-block
Sep 5, 2022
Merged
Navigation: Set the icon control to full width. #43844
kevin940726
merged 1 commit into
trunk
from
fix/full-width-icon-control-navigation-block
Sep 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -142 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kevin940726
force-pushed
the
fix/full-width-icon-control-navigation-block
branch
from
September 5, 2022 12:28
5a9e67d
to
9e6b6bc
Compare
cbravobernal
changed the title
Set the icon control to full width in the navigation block
Navigation: Set the icon control to full width.
Sep 14, 2022
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
Needs User Documentation
Needs new user documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow-up to #43674. Set the icon control to full width.
Why?
See #37930 (comment) for the latest design.
How?
Use the
isBlock
prop.Testing Instructions
Screenshots or screencast