unescapeTerms/unescapeTerm: filter-out values of unexpected type #43728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +10 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
fullofcaffeine
changed the title
fullofcaffeine
changed the title
Mamaduka
reviewed
Sep 1, 2022
There was a problem hiding this comment.
Thanks for the ping, @fullofcaffeine.
I can still see a similar error when following testing instructions from #40850.
I agree that we should make these utility methods resilient. But we should also fix the cause of the issue in the findOrCreateTerm function. I had some notes for the latter and will try to do a follow-up in a separate PR.
Screenshot
|
Here's my follow-up - #43766. |
Ah, you're right, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Filters out non-truthy values from the
termsargument passed tounescapeTerms. We're looking to filter outnullandundefinedvalues from it, but we go a bit further: we actually check that the structural type of the value is correct and if it's not, we don't do anything meaning the function will returnundefined- thisundefinedthat is then filtered-out byunescapedTerms.**Any other consuming code should take care handling a potential
undefinedvalue being returned fromunescapeTerm.As a bonus, we replace lodash's
mapwith the nativeArray.mapfunction.Why?
Even though it shouldn't receive an array with
undefined(ornull) values, we've seen instances of it around the code and when the value is finallymap'ed to theunescapeTermfunction, it will fail with aTypeError: Cannot read properties of undefined (reading name)because it expects an object of a certain structure, and ends up receiving something else (undefined). See this issue: #40850.How?
We keep only truthy values in the
termsarray beforemaping them againstunescapeTerm.Testing Instructions
TODO