Navigation: use code instead of keyCode for keyboard events
#43644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] UI Components
|
Size Change: -9 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use the
codeproperty instead ofkeyCodefor keyboard events in theNavigationcomponent.Why?
keyCodeis deprecated, and replaced bycodeHow?
Simply used the value for the
Escapekey as per the documentationTesting Instructions
In Storybook, visit the "Search" example for the
Navigationcomponent.Click on the magnifying glass to open the search input, and make sure that pressing the
Escapekey will close that input.(The text in that input won't show because its color is white — this looks like a bug that can also be reproduced in
trunk)