Verse: Add missing typography supports

[aaronrobertshaw]

Related:

• Tracking: Addressing Design Tooling Consistency #43241
• Tracking: Typography Design Tools Consistency #43242

What?

Adds missing typography supports to the Verse block.

Why?

• Improves consistency of our design tools across blocks.

How?

• Opts into missing text-decoration typography support.

Testing Instructions

1. Edit a post, add a Verse block, select it and enter some content.
2. Check that the text-decoration controls are now available.
3. Test various typography settings ensuring styles are applied in the editor.
4. Save and confirm their application on the frontend.
5. Test styling via theme.json

Example theme.json snippet:

			"core/verse": {
				"typography": {
					"textDecoration": "line-through"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-24.at.7.31.07.pm.mp4

[glendaviesnz]

This tested well for me, except not under global styles, should the text decoration option appear there as well under the Verse block?

[andrewserong]

should the text decoration option appear there as well

There isn't currently a control in the global styles UI for text decoration (in TypographyPanel), so I think we've been merging in the text decoration PRs intentionally without exposing it there?

Since text decoration is likely to be less used, from memory it was argued somewhere (possibly on one of these many PRs 😅) that it's okay if it appears as optional under the ToolsPanel menu, but in global styles we might not want to display it prominently, however theme authors can still use it via theme.json. Separately, we might want to eventually switch the TypographyPanel over to using the ToolsPanel, where we could then de-prioritise the text decoration control in the UI 🤔

[glendaviesnz]

Tested well for me:

✅ Could add text decoration to verse in block editor and was applied in editor and frontend
✅ Could add setting to theme.json and it was applied in editor and frontend

[aaronrobertshaw]

should the text decoration option appear there as well under the Verse block

When the text-decoration support was originally implemented, it was requested for it not to be exposed in Global Styles. The thinking was that text-decoration wasn't something that should be encouraged to be set globally by users however we should still offer it to theme authors (via theme.json).

In a recent audit of the Global Styles Typography panel, it still wasn't on the horizon for making a comeback. If it interests you, you can follow the current progress to refining that typography panel.