Lodash: Remove from block factory API #43560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
sgomes,
aristath,
gziolo,
swissspidy,
ellatrix,
jorgefilipecosta,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: +3 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
sgomes
approved these changes
Aug 24, 2022
| @@ -163,14 +153,14 @@ export function cloneBlock( block, mergeAttributes = {}, newInnerBlocks ) { | |||
| * @return {boolean} Is the transform possible? | |||
| */ | |||
| const isPossibleTransformForSource = ( transform, direction, blocks ) => { | |||
| if ( isEmpty( blocks ) ) { | |||
| if ( ! blocks.length ) { | |||
There was a problem hiding this comment.
Adding a note that blocks could in theory be undefined (in which case blocks?.length would be preferred), but the rest of the code on this file already appears to assume that it will always be an array 👍
There was a problem hiding this comment.
Tests pass so it’s probably working correctly but extra safety won’t hurt. I believe that isEmpty like most lodash methods was covering a few things including checking if we deal with an array in the first place.
There was a problem hiding this comment.
Yeah, this is a common problem with migrating away from Lodash, especially in untyped codebases 😕 It's hard to separate which checks we want to keep, and which ones are not needed. Implicit conversions are even worse.
Sometimes you get it wrong and create some bugs that need to be fixed, but the end result after all that is much better: not only are you not relying on a large lib anymore, but you're now explicit about your checks, which improves readability and maintainability. It's painful, but it's worth it 🙂
There was a problem hiding this comment.
TBH cases like isEmpty in combination with the untyped codebase makes it the ultimate hell for following through code and ensuring no bugs occur. By removing the extra ambiguity that isEmpty() added, we solve one of the problems, and then when one day we type the entire codebase, things will look great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash usage from the block factory API.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing all Lodash usage with native functionality.
Testing Instructions
npm run test:unit packages/blocks