Multi-select: Add transition to reduce chance of flash. #43510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Nice, this worked well for me. I also like that pressing Command+A feels nicer. |
|
Size Change: +33 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on #43313, I realized that as you are making a text-selection between two paragraphs, in the very brief time when the cursor is between the two paragraphs, the blue multi-select style flashes in:
This happens because in the space between those two blocks, one block is selected but not yet partially selected, which invokes the blue line.
By adding a small transition, we effectively eliminate this flash:
Why?
For basic text editing this makes for a clearer experience.
Testing Instructions
Please test partial selections between text, as well as multi selections between random blocks. Outside of the .1s transition, the behavior should be the same.