Group block: use a variation picker in the placeholder#43496

Merged

ramonjd merged 24 commits intotrunkfrom try/group-variation-placeholder

Nov 15, 2022

+446-50

Commits on Nov 15, 2022

Group block: remove default layout for the group block and use a variation picker in the placeholder.
ramonjd
committed
Updating e2e tests to select default group from group variation placeholder
ramonjd
committed
Adding meaningful aria label to block variation picker
ramonjd
committed
Only you..... can make my tests go green....
ramonjd
committed
Clicking on block variation skip button
ramonjd
committed
Clicking on block variation skip
ramonjd
committed
Programmatically creating a group block will not default to the constrained layout type. It must be specified.
ramonjd
committed
Reinstating default "constrained" layout type, but adding an extra ephemeral property to identify blocks that have been inserted.
ramonjd
committed
Ensure that the inserted block is selected after a Group variation is selected.
ramonjd
committed
Removing skip link and update description
ramonjd
committed
Reinstate skip for now until we can update the e2e tests
ramonjd
committed
Stylising the placeholder icons
ramonjd
committed
Adding isDefault to the default props and removing it when a group variation is selected.
ramonjd
committed
Updating tests to account for:
ramonjd
committed
Creating a custom group block variation picker so we do not have to update (and potentially break) the blockvariationpicker component, which is used elsewhere.
ramonjd
committed
Add missing button label.
ramonjd
committed
Update native test fixture
ramonjd
committed
Removing the isDefault Group block attribute. It's a fragile solution to keep track of whether a variation has been selected since it adds a potentially useless attribute.
ramonjd
committed
Ensure that we select the default group variation in the e2e tests.
ramonjd
committed
Creating custom hook for showPlaceholder
ramonjd
committed
Default selected layout type of Group variation is "constrained"
ramonjd
committed
Am I pretty enough for you, linter?
ramonjd
committed
Reverted
ramonjd
committed
Reinstating useEffect so that we can react to changes in the style state.
ramonjd
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Group block: use a variation picker in the placeholder#43496

Commits on Nov 15, 2022

Group block: remove default layout for the group block and use a variation picker in the placeholder.

Updating e2e tests to select default group from group variation placeholder

Adding meaningful aria label to block variation picker

Only you..... can make my tests go green....

Clicking on block variation skip button

Clicking on block variation skip

Programmatically creating a group block will not default to the constrained layout type. It must be specified.

Reinstating default "constrained" layout type, but adding an extra ephemeral property to identify blocks that have been inserted.

Ensure that the inserted block is selected after a Group variation is selected.

Removing skip link and update description

Reinstate skip for now until we can update the e2e tests

Stylising the placeholder icons

Adding `isDefault` to the default props and removing it when a group variation is selected.

Updating tests to account for:

Creating a custom group block variation picker so we do not have to update (and potentially break) the blockvariationpicker component, which is used elsewhere.

Add missing button label.

Update native test fixture

Removing the `isDefault` Group block attribute. It's a fragile solution to keep track of whether a variation has been selected since it adds a potentially useless attribute.

Ensure that we select the default group variation in the e2e tests.

Creating custom hook for `showPlaceholder`

Default selected layout type of Group variation is "constrained"

Am I pretty enough for you, linter?

Reverted

Reinstating `useEffect` so that we can react to changes in the style state.