Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Post Featured Image border attributes #43426

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Aug 19, 2022

What?

Adds checks for the border attributes in Post Featured Image if they exist. Introduced here: #42847

Without the checks there are php notices when a Post Featured Image has no border attributes.



Notice: Undefined index: classnames in /var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/post-featured-image.php on line 106
--
Notice: Undefined index: css in /var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/post-featured-image.php on line 107

@ntsekouras ntsekouras added the [Type] Bug An existing feature does not function as intended label Aug 19, 2022
@ntsekouras ntsekouras self-assigned this Aug 19, 2022
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me. I would appreciate another sanity check but it looks right to me.

@ntsekouras ntsekouras force-pushed the fix/featured-image-regression branch from aeb2a8d to 5d36c1d Compare August 19, 2022 12:00
@ntsekouras ntsekouras force-pushed the fix/featured-image-regression branch from f5c203e to 1c464db Compare August 19, 2022 13:03
@ntsekouras ntsekouras merged commit d6b928d into trunk Aug 19, 2022
@ntsekouras ntsekouras deleted the fix/featured-image-regression branch August 19, 2022 14:45
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 19, 2022
@ntsekouras ntsekouras added the [Block] Post Featured Image Affects the Post Featured Image Block label Aug 19, 2022
@aaronrobertshaw
Copy link
Contributor

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Featured Image Affects the Post Featured Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants