Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Author: Add missing typography supports #43317

Merged

Conversation

aaronrobertshaw
Copy link
Contributor

Depends On:

Related:

What?

Adds missing font-family and text-decoration typography support to the Post Author block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing font-family and text-decoration typography support.

Testing Instructions

  1. Edit a post, add a Post Author block, and select it.
  2. Check that the font-family and text-decoration controls are now available.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Apply the changes from Duotone: Prevent early return blocking other style generation #43300 to this branch (fixes duotone bug breaking global styles)
  6. Switch to the site editor and add a Post Author to a page or template.
  7. Navigate to Global Styles > Blocks > Post Author > Typography and apply typography styles there.
  8. Confirm the selected styles are reflected in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-17.at.8.01.27.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Post Author Affects the Post Author Block [Feature] Typography Font and typography-related issues and PRs labels Aug 17, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 17, 2022
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing nicely for me in the post editor and global styles with #43300 applied. Both font family and text decoration are applied to all text elements within the block, including the author bio if provided in the user settings:

image

LGTM! ✨

@aaronrobertshaw aaronrobertshaw merged commit 93be308 into trunk Aug 19, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-post-author branch August 19, 2022 05:07
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 19, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Author Affects the Post Author Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants