Calendar: add color block supports #43299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
Size Change: +88 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
I missed that one, thanks for linking to it @carolinan
I'll comment over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Enabling full color block supports for the calendar block.
Because the gallery block has a hardcoded background color for
thand a hardcoded color fortbodyandcaption, this PR updates the CSS to limit these hardcoded colors where there's nohas-textorhas-backgroundclasses.⚠⚠⚠ Note: updating the colors with custom values doesn't work reliably.
When selecting a preset color, followed by a custom color, the block doesn't rerender.
I've pinpointed it to the use of useDebounce in the ServerSideRender component.
The debounced function is called, but it doesn't fire. I suspect that it's cancelled too early here.
Maybe there's an equality check that's failing, because if add a
_key: Math.random()to the top level of the attributes, or as part of the GET query args via urlQueryArgs it works.The effect is easier to see if both
"color.background"and"color.gradients"block supports are opted into.Why?
To add the option to provide a background color to gallery blocks.
To create consistency across blocks.
How?
Adding the relevant block supports in block.json
Testing Instructions
2022-08-17.14.16.44.mp4