Pullquote block: remove font definition from the default block styles #43195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to make it customizable using theme.json
|
Size Change: -328 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
…e.json definitions
matiasbenedetto
changed the title
matiasbenedetto
added
[Block] Pullquote
carolinan
reviewed
Aug 15, 2022
| }, | ||
| "__experimentalStyle": { | ||
| "typography": { | ||
| "fontSize": "1.5em", |
There was a problem hiding this comment.
Can you clarify why this font size was chosen? Only because it is in between the two current values?
(I do not know why there were two font sizes in the first place)
There was a problem hiding this comment.
Yep, I chose that font size because it is in the middle of the previous 2 sizes used here, with the intention of fixing the problem and causing fewer possible changes on sites using already using the block.
carolinan
approved these changes
Aug 15, 2022
This was referenced Aug 26, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Pullquote block: remove font definition from the default block styles to make it customizable using theme.json
Why?
Because currently the font settings from a theme's theme.json file, such as font size and line height, are being overridden by the default block styles.
Currently it doesn't work well because the theme.json targets .
wp-block-pullquoteand the built-in block css targets.wp-block-pullquote pso the theme.json definition is overridden.So if we set this in theme.json
We get that size modified by the relative
emunit specified by the block CSS with a more specific selector.How?
In this PR I'm removing the CSS definitions from the block CSS and adding it to block.json
.
Testing Instructions
theme.jsonfileScreenshots or screencast
Before:
pullquote.font.size.before.mp4
After:
pullquote.font.size.mp4