-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable alpha (opacity) in Global Styles color pickers. #43045
Enable alpha (opacity) in Global Styles color pickers. #43045
Conversation
This solution was tested and proved to work as expected here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndiego, do you happen to know the PR that enabled alpha colors?
I think this change will enable alpha support everywhere the PaletteEdit
component is used. Do we want this?
@Mamaduka yeah it will, but it only looks like I believe this is the original PR for alpha support: #37731 I did just test a few additional things, such as setting colors with opacity at the block level in Global Styles and then exporting the changes. The exported theme.json file correctly includes the alpha hex codes. Reimporting the theme and then making additional changes in Global Styles all work as expected. I believe we should move forward with this for 13.9 and then continue testing. If we need to restrict alpha functionality elsewhere, we can prior to 6.1, but this PR moves us closer to consistency between the Editors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndiego, okay, let's give this a try. It should be easy to revert.
Thanks @Mamaduka and @carolinan! 🚢ing |
Cherry-picked to the 13.9 branch and released in Gutenberg 13.9-rc2 ✅ |
What?
Enables alpha (opacity) in Global Styles color pickers which fixes #42999 and #43041
Why?
Alpha was enabled previously at the block level but not in Global Styles. This PR corrects that and establishes consistency.
How?
Simply add
enableAlpha
to theColorPicker
component that is used in Global Styles.Testing Instructions
Screenshots or screencast