Make template part and reusable block creation language consistent #43032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
jameskoster
requested review from
ntwb,
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
Size Change: +2 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
Thanks for sweating the details! I could be overthinking this, but there's something about "Create" that makes the wording feel detached from the current selection which "Add to" doesn't. Even "Group" feels like it's about to group the current selection. I like "Create Reusable block" more than "Make Reusable block" — but the latter might be more contextual? What's your take on that thought? |
|
I agree with the observation if the menu item existed in a vacuum, but isn't the action attached to the current selection by virtue of being accessed via the block toolbar? 🤔 I suppose we could go the other way if it's preferable;
|
jameskoster
deleted the
update/template-part-reusable-block-creation-language
branch
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates menu items that enable reusable block or template part creation to use consistent language.
Why?
Consistent language surrounding similar features strengthens trust in the overall UX.
How?
The following text strings are updated:
I chose "Create" because it is short, and aligns with both the modal titles in the creation flow, and the confirmation snackbars post creation, e.g. "Template part created". But there are other options we might consider – let's discuss!
In addition to the language update, I appended an icon to the "Create Template part" menu item.
Testing Instructions
In the site editor select a block, open the more options menu and observe the two menu items: