Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popover: fix limitShift logic by adding iframe offset correctly (and a custom shift limiter) #42950
Popover: fix limitShift logic by adding iframe offset correctly (and a custom shift limiter) #42950
Changes from all commits
09773f1
cf71889
61da3a0
5f67818
fce608e
d0db89a
c12aba4
6dc52d7
8d01dbf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no TS expert, but I wonder if it's worth extracting this to a separate type to make this easier to read ...
e.g.
Although I'm not sure if this is a case where you want to keep the code as close to the floating-ui implementation as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely agree that parts of this type could be extracted to make the overall type less verbose / easier to understand
That is the rationale that I adopted when writing the custom limiter function. I basically tried to make the least amount of changes possible compared to the original function.
For now I've kept the code as-is, but let me know if you have a strong preference for simplifying the types and I can definitely do something about it.