Layout: Document the current state of the layout block support #42619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Developer Documentation
This was referenced Aug 2, 2022
Closed
andrewserong
force-pushed
the
try/documenting-the-layout-block-support
branch
from
56a5d88 to
1dbb50a
Compare
andrewserong
changed the title
andrewserong
force-pushed
the
try/documenting-the-layout-block-support
branch
from
8df0b84 to
4db074e
Compare
andrewserong
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
andrewserong
added
[Feature] Layout
ramonjd
approved these changes
Oct 5, 2022
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
tellthemachines
approved these changes
Oct 5, 2022
Co-authored-by: tellthemachines <tellthemachines@users.noreply.github.com>
|
Thanks for all the feedback @ramonjd and @tellthemachines, I've pushed updates to address each of the notes. I doubt the performance tests will be finished before I wrap up for the day, so I'll look at merging this in tomorrow.
On this note, I always love detailed feedback on grammar, so very happy for these sorts of comments and explanations! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Following on from #40875 and as part of #39336, this PR attempts to document the current state of the Layout block support.
Why?
While the Layout block support is currently an experimental feature, it is only experimental in the sense that the API is unstable and likely to change. The feature is in use in core and production sites, so while it is experimental, let's attempt to document the current state of the layout support, the purpose and intention behind it, and what it outputs.
The goal with this PR should be to help make it easier to understand how and why things are happening, and also how to opt-in or opt-out of the behaviour as needed (tying into #42544)
How?
stylesarchitecture page to include a section on Layout. If need be, we could always pull Layout into a separate file, but I think it makes sense to keep it with the other styles topics.Tasks
blockGapstyles and expose the UI for itis-layout-constrainednow that the constrained layout type has been added: Try "constrained" content width as new layout type #42763Testing Instructions
👀 Proofread and verify that the information is accurate 😄