Layout: Add not .alignfull rule from root CSS PR #42614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
the
[Type] Regression
|
Size Change: +6 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Tested with Twenty Twenty Two by following the steps outlined in #42604 and can confirm this fixes the issue for fullwidth blocks in both the front end and the editor (provided the theme styles define negative margins for the block).
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
andrewserong
added
the
[Feature] Layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As reported in #42604, Gutenberg 13.7 was released but didn't include the fix for full width alignment introduced in #42085 (that PR is slated for 13.8).
This PR attempts to grab a couple of the fixes for the full width alignment, and targets the
release/13.7branch. This PR exists in case it's desired to push a patch / point release without having to include or cherry pick all of #42085.Why?
Due to the issue in #42604 causing issues for TwentyTwentyTwo (or themes with their own custom negative margin rules for full width alignment blocks) it could be worth a higher priority fix than waiting for 13.8.
How?
Add the
:not(.alignfull)pseudo class rule to the content size and flow layouts so that the!importantmargin-left and margin-right rules aren't applied to full width alignment blocks.Testing Instructions
Follow the testing steps in #42604 and see if this PR resolves the issue. Is it enough as a shorter-term fix, or do we need to revisit the specificity of the selectors?
Screenshots or screencast